Print overload name in print_ops_info #5404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5404
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e7235b7 with merge base 3befc8a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62786631 |
Summary: As titled. This is helpful when the aten ops have many overloads, e.g. `aten.mean.out` or `aten.mean.dim_out` Differential Revision: D62786631
facebook-github-bot
force-pushed
the
export-D62786631
branch
from
de0eb43
to
e7235b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62786631 |
dulinriley
approved these changes
Sep 17, 2024
Comment on lines
+107
to
+108
| if node.target._name in freq: | ||
| freq[node.target._name] += 1 |
There was a problem hiding this comment.
What's the meaningful difference here? Looks like in tests it's the difference between aten.linear and aten::linear?
|
This pull request has been merged in 0658dce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. This is helpful when the aten ops have many overloads, e.g.
aten.mean.outoraten.mean.dim_outDifferential Revision: D62786631