Clean up LlamaDemo test on AWS #5340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5340
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9340627 with merge base fe53d41 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
approved these changes
Sep 13, 2024
|
Oh... Sorry I didn't realize my changes impacts LlamaDemo. But true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #5240, the test spec becomes more catered toward Minibench, it doesn't work with LlamaDemo anymore because of the different model path. So, LlamaDemo test on AWS is currently failing in trunk https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=test-llama-app. I think this job has outlived its usefulness and can be cleaned up. We already have android-perf workflow in its place.