Mark thread-safe methods of DataLoader as const. #4756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4756
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ce57936 with merge base b75e7d7 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61406229 |
|
This pull request was exported from Phabricator. Differential Revision: D61406229 |
shoumikhin
force-pushed
the
export-D61406229
branch
from
9bcc626
to
3f94b2a
Compare
dbort
approved these changes
Aug 16, 2024
Summary: Pull Request resolved: #4756 Every DataLoader must not modify its internal state after initialization so that it can be shared and used by multiple threads simultaneously. Reviewed By: dbort Differential Revision: D61406229
shoumikhin
force-pushed
the
export-D61406229
branch
from
3f94b2a
to
ce57936
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61406229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Every DataLoader must nost modify its internal state after initialization so that it can be shared and used by multiple threads simultaneously.
Differential Revision: D61406229