-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core ML] Implement intermediate tensor logging #4557
[Core ML] Implement intermediate tensor logging #4557
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4557
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit eca7a38 with merge base 2718dd4 (): NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
80276dc
to
4728a65
Compare
@Olivia-liu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, it looks good! Thanks for working on the integration. Just one line in the cmake file I need clarification on if you don't mind
4728a65
to
2996cb8
Compare
2580d1e
to
eca7a38
Compare
@Olivia-liu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Thanks for addressing the comment! I just imported again. By the way, next time when the PR is ready for review again, can you click the Re-request review button, please? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try rebasing to resolve the 2 OSS CI failures.
Hi @cymbalrush, sorry we're reverting this pr because it breaks the CI. Do you mind sending out the PR again and address the IC? Thanks! |
Differential Revision: D60838372 Pull Request resolved: pytorch#4557
ModelEventLoggerImpl
to log intermediate tensor values.sdk_example_runner
to buildCore ML
when specified.debugger_cli
script to compare intermediate tensor values of a program executed using optimized kernels and delegated toCore ML
.Testing:
python examples/apple/coreml/scripts/debugger_cli.py -m softmax
to compare intermediate tensors