-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support devices and delegates parameters in android-perf workflow #4484
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4484
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 73144c5 with merge base 4483bb6 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
f488eb2
to
0f602a2
Compare
@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a note that this setup means that when there are multiple models, all of them need to be exported successfully before the benchmark job could start. It is simpler but people might want more flexibility to stop models that fail to export while continue with models that are exported successfully. We can consider that feature later if there is an ask for it.
Yes, that's a good point. We can address it later when we can support multiple models. It's easy to do but the tricky part is that we don't want it being a surprise if they scheduled to run 10 models but only 1 gets run at the end. We will need to surface the model export failures to users in a more explicit way other than log the failure in the CI, e.g. making it part of the final report or dumped file. |
0f602a2
to
73144c5
Compare
@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
The workflow can support parameters
models
,devices
,delegates
.The workflow is able to translate
devices
todevice-pool-arn
and pass to themobile_job
for schedulingThe model is packed and uploaded to
artifacts/{model}_{backend}/model.zip
Note: We should only expect the scheduling is working correctly by passing models, devices and delegates. The actual job may not finish successfully because the underlying model/delegate/device are not supported yet.
Test:
The workflow scheduling is working as expected: https://github.com/pytorch/executorch/actions/runs/10187260307