Support qmatmul with different dims tensors #4438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4438
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1087859 with merge base 1e4603d ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60314979 |
dulinriley
approved these changes
Jul 29, 2024
Comment on lines
+208
to
+213
| # Combine the larger batch dimensions with the matmul output size | ||
| out_size = ( | ||
| X_batch_dims + mat_size | ||
| if len(X_batch_dims) > len(Y_batch_dims) | ||
| else Y_batch_dims + mat_size | ||
| ) |
There was a problem hiding this comment.
Why combine the larger of the two batch dims? Perhaps it should just default to the first argument's instead?
This would seem like unpredictable behavior to someone using this function.
Summary: Pull Request resolved: #4438 MobileBERT exposes an issue in our kernel, where tensors have compatible (for PyTorch) but different batch dimensions. This diff changes the meta kernel to support that (the kernel can already do it). Reviewed By: dulinriley Differential Revision: D60314979
|
This pull request was exported from Phabricator. Differential Revision: D60314979 |
mcremon-meta
force-pushed
the
export-D60314979
branch
from
5524ec1
to
1087859
Compare
|
This pull request has been merged in f695f8e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
MobileBERT exposes an issue in our kernel, where tensors have compatible (for PyTorch) but different batch dimensions.
This diff changes the meta kernel to support that (the kernel can already do it).
Differential Revision: D60314979