Skip to content

Use rpath for pypi artifact #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kirklandsign merged 3 commits into from
Jul 25, 2024
Merged

Use rpath for pypi artifact #4411

kirklandsign merged 3 commits into from
Jul 25, 2024

Conversation

@kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Jul 25, 2024

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4411

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 2d0fca5 with merge base 4b6331d (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2024
@kirklandsign kirklandsign added ciflow/binaries ciflow/binaries/all Release PRs with this label will build wheels for all python versions and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 25, 2024
larryliu0820
larryliu0820 reviewed Jul 25, 2024
View reviewed changes
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2024
kirklandsign
kirklandsign commented Jul 25, 2024
View reviewed changes
@kirklandsign
Update CMakeLists.txt
2d0fca5 
add $ORIGIN as well
@kirklandsign kirklandsign merged commit 97f7727 into release/0.3 Jul 25, 2024
@kirklandsign kirklandsign deleted the fix-pypi-artifact branch July 25, 2024 06:44
@pytorch pytorch deleted a comment from pytorch-bot bot Jul 25, 2024
@pytorch pytorch deleted a comment from pytorchbot Jul 25, 2024
kirklandsign added a commit to kirklandsign/executorch that referenced this pull request Aug 1, 2024
@kirklandsign
Use rpath for pypi artifact (pytorch#4411)
a393dcf 
* Use rpath for pypi artifact

* fix path

* Update CMakeLists.txt

add $ORIGIN as well

(cherry picked from commit 97f7727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees

No one assigned

Labels

ciflow/binaries/all Release PRs with this label will build wheels for all python versions ciflow/binaries CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kirklandsign @larryliu0820 @facebook-github-bot