Enable aten.relu_.default in the CadenceQuantizer #4344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As titled. The kernel will be used by the quantizer but is missing the meta kernel. Differential Revision: D60070844
Summary: As titled. Some model use `torch.ops.aten.relu_.default` instead of `torch.ops.aten.relu.default`. Enable that in the quantizer. Differential Revision: D60071019
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4344
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1ffc76e with merge base f0364e8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60071019 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Summary: As titled. Some model use `torch.ops.aten.relu_.default` instead of `torch.ops.aten.relu.default`. Enable that in the quantizer. Differential Revision: D60071019
zonglinpengmeta
approved these changes
Jul 23, 2024
| @@ -31,7 +31,6 @@ | |||
| lib.define( | |||
| "quantized_layer_norm(Tensor X, Tensor X_scale, Tensor X_zero_point, int[] normalized_shape, Tensor weight, Tensor bias, float eps, float output_scale, int output_zero_point) -> (Tensor Y)" | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
white lines removed by accident?
There was a problem hiding this comment.
no I made all cases look the same (grouping default and out overloads)
|
This pull request has been merged in 48da61a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. Some model use
torch.ops.aten.relu_.defaultinstead oftorch.ops.aten.relu.default. Enable that in the quantizer.Differential Revision: D60071019