Provide kernels with true reference implementations for quantized ops #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4108
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 150d4ab with merge base 7047162 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59238748 |
|
This pull request was exported from Phabricator. Differential Revision: D59238748 |
mcremon-meta
added a commit
that referenced
this pull request
Jul 11, 2024
…#4108) Summary: Pull Request resolved: #4108 We want to be able to run the reference implementations on x86, so we don't want any intrinsics or anything like that in the reference kernels. In the end, this change has a lot of things: - introduce a `reference` folder for reference implementations - moved the primary cmake flow from HiFi to reference, so that the default mode can run on x86 - that means we will need a proper flag to use HiFi optimized ops, which we will add later - add a `quantized_matmul` reference kernel Differential Revision: D59238748
mcremon-meta
force-pushed
the
export-D59238748
branch
from
a9f0c4d
to
beb0137
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59238748 |
mcremon-meta
added a commit
that referenced
this pull request
Jul 12, 2024
…#4108) Summary: Pull Request resolved: #4108 We want to be able to run the reference implementations on x86, so we don't want any intrinsics or anything like that in the reference kernels. In the end, this change has a lot of things: - introduce a `reference` folder for reference implementations - moved the primary cmake flow from HiFi to reference, so that the default mode can run on x86 - that means we will need a proper flag to use HiFi optimized ops, which we will add later - add a `quantized_matmul` reference kernel Differential Revision: D59238748
mcremon-meta
force-pushed
the
export-D59238748
branch
from
beb0137
to
9215276
Compare
…#4108) Summary: Pull Request resolved: #4108 We want to be able to run the reference implementations on x86, so we don't want any intrinsics or anything like that in the reference kernels. In the end, this change has a lot of things: - introduce a `reference` folder for reference implementations - moved the primary cmake flow from HiFi to reference, so that the default mode can run on x86 - that means we will need a proper flag to use HiFi optimized ops, which we will add later - add a `quantized_matmul` reference kernel Differential Revision: D59238748
|
This pull request was exported from Phabricator. Differential Revision: D59238748 |
mcremon-meta
force-pushed
the
export-D59238748
branch
from
9215276
to
150d4ab
Compare
dulinriley
approved these changes
Jul 16, 2024
|
This pull request has been merged in ef640bf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We want to be able to run the reference implementations on x86, so we don't want any intrinsics or anything like that in the reference kernels.
In the end, this change has a lot of things:
referencefolder for reference implementationsquantized_matmulreference kernelDifferential Revision: D59238748