Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the quantization API to OSS #3997

Closed
wants to merge 1 commit into from
Closed

Conversation

mcremon-meta
Copy link
Contributor

Summary: As titled.

Differential Revision: D58680953

Summary: As titled.

Differential Revision: D58680953
Copy link

pytorch-bot bot commented Jun 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3997

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 19fa9ed with merge base bcabc37 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58680953

Comment on lines +32 to +33
# pyre-ignore[33]: `InputsArgsType` cannot alias to `Any`.
InputsArgsType = Tuple[Any, ...]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps object instead to fix this error message?

Suggested change
# pyre-ignore[33]: `InputsArgsType` cannot alias to `Any`.
InputsArgsType = Tuple[Any, ...]
InputsArgsType = Tuple[object, ...]

Comment on lines +53 to +54
# Calibrate
prepared_model(*inputs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to calibrate with more than one sample normally for good PTQ accuracy. Is this API meant more for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup this is all dummy for now. We don't even look at quantization accuracy, only implementation accuracy (ref outputs are from the converted forward model).

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d11e8e1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants