Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update llama readme, use main branch for llama3 #3861

Closed
wants to merge 1 commit into from
Closed

Update llama readme, use main branch for llama3 #3861

wants to merge 1 commit into from

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jun 5, 2024

Summary:
Use main branch for llama3. Looks like the warning was removed in D56358723 ?

See: #3850

Differential Revision: D58212855

@lucylq @facebook-github-bot
Update llama readme, use main branch for llama3
38e1168 
Summary:
Use main branch for llama3. Looks like the warning was removed in D56358723 ?

See: pytorch#3850

Differential Revision: D58212855
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3861

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 38e1168 with merge base 7bb2c58 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58212855

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c350075.

@mergennachin
Copy link
Contributor

@pytorchbot cherry-pick --onto release/0.2 -c docs

@mergennachin
Copy link
Contributor

@lucylq - This needs to go into release branch actually. Having this only in main branch won't really add value since they're already in main branch :)

Most likely it will cause a merge conflict into release branch. If it does, please do a manual merge (aka Option 2 in #3409)

Cc @mcr229

pytorchbot pushed a commit that referenced this pull request Jun 6, 2024
@lucylq @pytorchbot
Update llama readme, use main branch for llama3 (#3861)
0cd23b9 
Summary:
Pull Request resolved: #3861

Use main branch for llama3. Looks like the warning was removed in D56358723 ?

See: #3850

Reviewed By: larryliu0820

Differential Revision: D58212855

fbshipit-source-id: 82cc28e6e54946487dc00b00a3ec4c5f3e3f4e29
(cherry picked from commit c350075)
@pytorchbot
Copy link
Collaborator

Cherry picking #3861

The cherry pick PR is at #3871

Details for Dev Infra team Raised by workflow job

@mergennachin
Copy link
Contributor

Actually no merge conflict. Let's cherry-pick this one

@mergennachin mergennachin mentioned this pull request Jun 6, 2024
Closed
mergennachin pushed a commit that referenced this pull request Jun 6, 2024
@lucylq @mergennachin
Update llama readme, use main branch for llama3 (#3861)
ed9a3e8 
Summary:
Pull Request resolved: #3861

Use main branch for llama3. Looks like the warning was removed in D56358723 ?

See: #3850

Reviewed By: larryliu0820

Differential Revision: D58212855

fbshipit-source-id: 82cc28e6e54946487dc00b00a3ec4c5f3e3f4e29
(cherry picked from commit c350075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucylq @facebook-github-bot @mergennachin @pytorchbot @larryliu0820