Skip to content

[ET-VK] Fix OSS build + separate test build into its own CMakeLists.txt #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented May 23, 2024

Stack from ghstack (oldest at bottom):

Context

As title. In the next diff, the vulkan test binary will be added to CI.

Differential Revision: D57747739

Copy link

pytorch-bot bot commented May 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3724

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 762a21e with merge base 377c750 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SS-JIA added a commit that referenced this pull request May 23, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2024
@SS-JIA
Copy link
Contributor Author

SS-JIA commented May 23, 2024

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…MakeLists.txt"


## Context

As title. In the next diff, the vulkan test binary will be added to CI.

Differential Revision: [D57747739](https://our.internmc.facebook.com/intern/diff/D57747739)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request May 23, 2024
Pull Request resolved: #3724


## Context

As title. In the next diff, the vulkan test binary will be added to CI.



@imported-using-ghimport

Differential Revision: [D57747739](https://our.internmc.facebook.com/intern/diff/D57747739/)
ghstack-source-id: 227579464
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57747739

…MakeLists.txt"


## Context

As title. In the next diff, the vulkan test binary will be added to CI.

Differential Revision: [D57747739](https://our.internmc.facebook.com/intern/diff/D57747739)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request May 23, 2024
@SS-JIA
Copy link
Contributor Author

SS-JIA commented May 24, 2024

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…MakeLists.txt"


## Context

As title. In the next diff, the vulkan test binary will be added to CI.

Differential Revision: [D57747739](https://our.internmc.facebook.com/intern/diff/D57747739)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request May 24, 2024
Pull Request resolved: #3724


## Context

As title. In the next diff, the vulkan test binary will be added to CI.



@imported-using-ghimport

Differential Revision: [D57747739](https://our.internmc.facebook.com/intern/diff/D57747739/)
ghstack-source-id: 227626689
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57747739

@facebook-github-bot
Copy link
Contributor

@SS-JIA merged this pull request in 1343224.

kirklandsign pushed a commit to kirklandsign/executorch that referenced this pull request May 24, 2024
…rch#3724)

Summary:
Pull Request resolved: pytorch#3724

## Context

As title. In the next diff, the vulkan test binary will be added to CI.

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: kirklandsign

Differential Revision: D57747739

Pulled By: SS-JIA

fbshipit-source-id: 0829abb08849d5349751c63d2c0c5a5dc39ca553
@SS-JIA SS-JIA deleted the gh/SS-JIA/46/head branch January 24, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants