Clean up lowering APIs #3690
Closed
Clean up lowering APIs #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3690
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 453dd5e with merge base 705ac96 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57579738 |
dulinriley
approved these changes
May 21, 2024
| expo_program, compile_config=EdgeCompileConfig(_check_ir_validity=False) | ||
| expo_program, | ||
| compile_config=EdgeCompileConfig( | ||
| _check_ir_validity=False, _skip_dim_order=True |
There was a problem hiding this comment.
What's this added _skip_dim_order kwarg for?
| inputs: Tuple[Any, ...], | ||
| dump_graphs: bool = False, | ||
| ) -> EdgeProgramManager: | ||
| edge_program_manager = export_to_edge(model, inputs) |
There was a problem hiding this comment.
Should this just take in an EdgeProgramManager that separately had export_to_edge called so that the APIs can be combined?
| to_edge_ops_count = get_ops_count(to_edge_gm) | ||
| jarvis_ops_count = get_ops_count(jarvis_gm) | ||
|
|
||
| # De-duplicate the "<op>" and "<op>_copy" ops |
Summary: Changes some types in `export_to_edge`, add an `export_to_cadence` function, and refactor some calls. Mostly preemptive work before adding a lot of AoT passes. Reviewed By: dulinriley, zonglinpengmeta Differential Revision: D57579738
mcremon-meta
force-pushed
the
export-D57579738
branch
from
09e215d
to
453dd5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57579738 |
|
This pull request has been merged in ed2da4f. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
May 24, 2024
Summary: Pull Request resolved: pytorch#3690 Changes some types in `export_to_edge`, add an `export_to_cadence` function, and refactor some calls. Mostly preemptive work before adding a lot of AoT passes. Reviewed By: dulinriley, zonglinpengmeta Differential Revision: D57579738 fbshipit-source-id: 8c7975488636bd946894f7f7e62da7e76eb29c65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Changes some types in
export_to_edge, add anexport_to_cadencefunction, and refactor some calls. Mostly preemptive work before adding a lot of AoT passes.Differential Revision: D57579738