gelu #3573
Closed
gelu #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3573
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0e1e6b5 with merge base 43bfcd2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57194536 |
copyrightly
added a commit
to copyrightly/executorch
that referenced
this pull request
May 10, 2024
Summary: - implemented `gelu` op, only `approximate="tanh"` is supported for now - added string data type in the codegen - added `extract_string` in `ComputeGraph.h` Differential Revision: D57194536
copyrightly
force-pushed
the
export-D57194536
branch
from
656931e
to
c2213ed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57194536 |
copyrightly
added a commit
to copyrightly/executorch
that referenced
this pull request
May 10, 2024
Summary: - implemented `gelu` op, only `approximate="tanh"` is supported for now - added string data type in the codegen - added `extract_string` in `ComputeGraph.h` Reviewed By: yipjustin Differential Revision: D57194536
copyrightly
force-pushed
the
export-D57194536
branch
from
c2213ed
to
e8b4570
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57194536 |
yipjustin
approved these changes
May 10, 2024
copyrightly
force-pushed
the
export-D57194536
branch
from
e8b4570
to
1a3a75f
Compare
copyrightly
added a commit
to copyrightly/executorch
that referenced
this pull request
May 11, 2024
Summary: - implemented `gelu` op, only `approximate="tanh"` is supported for now - added string data type in the codegen - added `extract_string` in `ComputeGraph.h` Reviewed By: yipjustin, jorgep31415 Differential Revision: D57194536
Summary: - implemented `gelu` op, only `approximate="tanh"` is supported for now - added string data type in the codegen - added `extract_string` in `ComputeGraph.h` Reviewed By: yipjustin, jorgep31415 Differential Revision: D57194536
|
This pull request was exported from Phabricator. Differential Revision: D57194536 |
copyrightly
force-pushed
the
export-D57194536
branch
from
1a3a75f
to
0e1e6b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57194536 |
|
This pull request has been merged in 60c94e8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
geluop, onlyapproximate="tanh"is supported for nowextract_stringinComputeGraph.hDifferential Revision: D57194536