Disable view_copy elimination for graph outputs #3565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3565
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ea60aef with merge base cc11541 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57132664 |
Summary: If the `view_copy` op is a graph output, leave it as a view_copy for now since the output pointer may be modified at runtime when deploying on device. Right now, the modified pointer would be ignored since the view_copy op will always point to its predecessor memory. cc chrismthompson jcoriell fengwang Differential Revision: D57132664
mcremon-meta
force-pushed
the
export-D57132664
branch
from
aec9d68
to
ea60aef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57132664 |
JacobSzwejbka
approved these changes
May 9, 2024
|
This pull request has been merged in 0563aa7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If the
view_copyop is a graph output, leave it as a view_copy for now since the output pointer may be modified at runtime when deploying on device.Right now, the modified pointer would be ignored since the view_copy op will always point to its predecessor memory.
cc chrismthompson jcoriell fengwang
Differential Revision: D57132664