[BE] Fix compilation on older Linux flavors #3262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As isinf on this platform is not really standard compliant (i.e. it's `int isinf(long double)` )
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3262
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a12d452 with merge base 329184a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
malfet
commented
Apr 24, 2024
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
malfet
changed the title
kimishpatel
approved these changes
Apr 24, 2024
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
manuelcandales
approved these changes
Apr 24, 2024
malfet
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix
cannot resolve overloaded function ‘isinf’ based on conversion to type ‘torch::executor::FunctionRef<bool(double)>’error, even though it should work on modern OSes(see https://godbolt.org/z/nYfP93f4K ) , it does not hurt to explicitly cast overloaded function to the form we expect it to be