-
Notifications
You must be signed in to change notification settings - Fork 607
Create dependabot rule to upgrade TorchFix version #3208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The parameters are from From https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file ### Testing On my own fork https://github.com/huydhn/executorch/blob/main/.github/dependabot.yml, and the PR to upgrade TorchFix is created successfully huydhn#2
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3208
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 27dc07c with merge base 8dc54d5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Why not just unpin? |
Like PT, ET is currently pinned all their dependencies as part of Docker image build, so I think having a PR like huydhn#2 would allow ET owners to control the upgrade process and land the PR only when it looks good. Also, creating a dependabot.yml might be useful for other packages in the future. |
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
I switch the reviewer to |
There is a chance that new TorchFix release will introduce CI failures after new rules added to TorchFix. |
@pytorchbot drci |
The parameters are from From https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
Testing
On my own fork https://github.com/huydhn/executorch/blob/main/.github/dependabot.yml, and the PR to upgrade TorchFix is created successfully huydhn#2