Skip to content

Create dependabot rule to upgrade TorchFix version #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Apr 22, 2024

@huydhn huydhn requested a review from kit1980 April 22, 2024 17:50
Copy link

pytorch-bot bot commented Apr 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3208

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 27dc07c with merge base 8dc54d5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2024
@huydhn huydhn marked this pull request as ready for review April 22, 2024 17:52
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kit1980
Copy link
Contributor

kit1980 commented Apr 22, 2024

Why not just unpin?

@huydhn
Copy link
Contributor Author

huydhn commented Apr 22, 2024

Why not just unpin?

Like PT, ET is currently pinned all their dependencies as part of Docker image build, so I think having a PR like huydhn#2 would allow ET owners to control the upgrade process and land the PR only when it looks good.

Also, creating a dependabot.yml might be useful for other packages in the future.

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@huydhn
Copy link
Contributor Author

huydhn commented Apr 22, 2024

I switch the reviewer to pytorch/team-executorch as they are the owners.

@kit1980
Copy link
Contributor

kit1980 commented Apr 22, 2024

There is a chance that new TorchFix release will introduce CI failures after new rules added to TorchFix.
I wonder how this going to be handled in the dependabot workflow.

@huydhn
Copy link
Contributor Author

huydhn commented Apr 22, 2024

@pytorchbot drci

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in dbf90c2.

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants