Skip to content

Update setup.sh for tokenizer selection #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Apr 22, 2024

Summary: For LLAMA3, users need to use tiktoken. Add a option to load from env var.

Next step: Remove 3P deps from extension/android, but use llama_runner directly

Differential Revision: D56430637

Copy link

pytorch-bot bot commented Apr 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3207

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 5863d1a with merge base 8dc54d5 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2024
Summary: For LLAMA3, users need to use tiktoken. Add a option to load from env var.

Differential Revision: D56374673
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign merged this pull request in 1a93dee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants