Fix embedding_4bit out variant #3151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3151
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 88e5fc8 with merge base 2c467dd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56357762 |
Summary: In #3095 there's an issue with the embedding_4bit schema which causes mismatch between functional and out variant. P1217884556 Differential Revision: D56357762
larryliu0820
force-pushed
the
export-D56357762
branch
from
ded3d25 to
88e5fc8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56357762 |
mergennachin
approved these changes
Apr 19, 2024
|
This pull request has been merged in 269b6ad. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In #3095 there's an issue with the embedding_4bit schema which causes mismatch between functional and out variant. P1217884556
Differential Revision: D56357762