Adjust MethodMeta's non-const indices by 1, and update all users #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48762563 |
|
This pull request was exported from Phabricator. Differential Revision: D48762563 |
4 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D48762563 |
|
This pull request was exported from Phabricator. Differential Revision: D48762563 |
|
This pull request was exported from Phabricator. Differential Revision: D48762563 |
|
This pull request was exported from Phabricator. Differential Revision: D48762563 |
Summary: First step in hiding the off-by-one non-const buffer indices from users. Since fewer users use `MethodMeta::num_non_const_buffers` today (relative to the version on Program), update the behavior here, along with all of its users. After this, we can migrate the users of `Program::get_non_const_buffer_size` to this new API, fixing the off-by-one as we go. I found all of these uses with the search ``` cd fbsource xbgs -sl "non_const_buffer_size" | xargs grep -le '\<non_const_buffer_size\>' ``` Luckily, `Program`'s version of this is called `get_non_const_buffer_size` (with the extra `get_` prefix) so it was straightforward to find code that used `MethodMeta`'s methods. Differential Revision: D48762563
|
This pull request was exported from Phabricator. Differential Revision: D48762563 |
|
This pull request has been merged in 5762802. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
First step in hiding the off-by-one non-const buffer indices from users. Since fewer users use
MethodMeta::num_non_const_bufferstoday (relative to the version on Program), update the behavior here, along with all of its users.After this, we can migrate the users of
Program::get_non_const_buffer_sizeto this new API, fixing the off-by-one as we go.I found all of these uses with the search
Luckily,
Program's version of this is calledget_non_const_buffer_size(with the extraget_prefix) so it was straightforward to find code that usedMethodMeta's methods.Differential Revision: D48762563