Skip to content

Free Vulkan delegate segments after loading #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jorgep31415
Copy link
Contributor

Summary:
It's been a while since I had an impactful one-liner. :)

Nothing innovative here, just reusing the same solution as other backends.

Differential Revision: D56281665

Copy link

pytorch-bot bot commented Apr 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3116

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0f8b4e1 with merge base e69a662 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/periodic module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ labels Apr 18, 2024
Copy link

pytorch-bot bot commented Apr 18, 2024

Warning: Unknown label ciflow/periodic.
Currently recognized labels are

  • ciflow/nightly
  • ciflow/trunk
  • ciflow/binaries
  • ciflow/binaries/all

Please add the new label to .github/pytorch-probot.yml

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56281665

jorgep31415 added a commit to jorgep31415/executorch that referenced this pull request Apr 18, 2024
Summary:

It's been a while since I had an impactful one-liner. :)

Nothing innovative here, just reusing the same solution as [other backends](https://github.com/pytorch/executorch/blob/b19d5860568187f2567d93dd5e7cd5af32378d9f/backends/xnnpack/runtime/XNNPACKBackend.cpp#L47-L48).

Reviewed By: yipjustin, copyrightly, SS-JIA

Differential Revision: D56281665
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56281665

Summary:
Pull Request resolved: pytorch#3116

It's been a while since I had an impactful one-liner. :)

Nothing innovative here, just reusing the same solution as [other backends](https://github.com/pytorch/executorch/blob/b19d5860568187f2567d93dd5e7cd5af32378d9f/backends/xnnpack/runtime/XNNPACKBackend.cpp#L47-L48).

Reviewed By: yipjustin, copyrightly, SS-JIA

Differential Revision: D56281665
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e0b0647.

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants