throw Java exception when execution fails #3112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Instead of logging, we throw a java exception and let user catch it. Reviewed By: dbcakadbc Differential Revision: D56270287
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3112
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e0731a3 with merge base 203ae40 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56270287 |
digantdesai
approved these changes
Apr 17, 2024
digantdesai
reviewed
Apr 18, 2024
| @@ -325,8 +325,8 @@ class ExecuTorchJni : public facebook::jni::HybridClass<ExecuTorchJni> { | |||
| #endif | |||
|
|
|||
| if (!result.ok()) { | |||
| ET_LOG( | |||
There was a problem hiding this comment.
Is this the only place we want to throw?
cccclai
approved these changes
Apr 18, 2024
|
This pull request has been merged in b19d586. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Instead of logging, we throw a java exception and let user catch it.
Reviewed By: dbcakadbc
Differential Revision: D56270287