Skip to content

[executorch][llm] Add tiktoken to eval #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Apr 15, 2024

No description provided.

Copy link

pytorch-bot bot commented Apr 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3044

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 912e51a with merge base eb44e88 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
@lucylq lucylq force-pushed the lfq.add-tiktoken-to-eval branch from f37ebcf to 6b874e3 Compare April 15, 2024 22:40
@lucylq lucylq marked this pull request as ready for review April 15, 2024 22:40
@facebook-github-bot
Copy link
Contributor

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@lucylq lucylq force-pushed the lfq.add-tiktoken-to-eval branch from 6b874e3 to 1f4960c Compare April 15, 2024 22:50
@facebook-github-bot
Copy link
Contributor

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter

Summary: Pull Request resolved: #3044

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

```
python -m examples.models.llama2.eval_llama --pte llama3_4_ckpts_x.pte -p ../llama-models/llama3/params_less.json -t ../llama-models/llama3/tokenizer.model --max_seq_len=127 --limit 5 
wikitext: {'word_perplexity,none': 22.00035213493939, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.8289244201951567, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.8709954573378033, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}
```

Reviewed By: larryliu0820

Differential Revision: D56163999

Pulled By: lucylq
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56163999

@facebook-github-bot
Copy link
Contributor

@lucylq merged this pull request in 780ed25.

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
@lucylq lucylq deleted the lfq.add-tiktoken-to-eval branch January 24, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants