Move compile spec to ArmTester interface #2991
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
freddan80
commented
Apr 11, 2024
freddan80
commented
- Create compile spec builder
- Added default compile spec for unit tests
- Cleaned up some redundant parameters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2991
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 7204b6b with merge base 57dd7f1 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
freddan80
added
ciflow/trunk
partner: arm
|
CI failure unrelated to this PR |
* Create compile spec builder * Added default compile spec for unit tests Change-Id: Ieae15b213969c703fc0bfcfd99a6a84ae3412676 Signed-off-by: Fredrik Knutsson <fredrik.knutsson@arm.com> Co-authored-by: Per Åstrand <per.astrand@arm.com>
freddan80
force-pushed
the
pr_move_comp_spec
branch
from
8da4d0a to
7204b6b
Compare
|
CI fails not related to this PR |
digantdesai
approved these changes
Apr 15, 2024
| self.path_for_intermediates = None | ||
| self.permute_nhwc = False | ||
|
|
||
| def ethosu_compile_spec( |
There was a problem hiding this comment.
why not just do this in __init__ or you can create a @classmethod if you want to write another constructor.
| self.output_format = "tosa" | ||
| return self | ||
|
|
||
| def dump_intermediate_tosa(self, output_path: str): |
There was a problem hiding this comment.
can all of these be @property?
So you can just do
builder.dump_intermediate_tosa = True
and
if builder.dump_intermediate_tosa
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mergennachin
approved these changes
Apr 15, 2024
|
@digantdesai merged this pull request in 64497b7. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.