[executorch] Use __ET_UNLIKELY in assertion macros #2949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is supposed to be unlikely for assert/check conditions to fail; let's tell the compiler about that. Differential Revision: [D55929730](https://our.internmc.facebook.com/intern/diff/D55929730/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2949
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 19cd437 with merge base 9fd1a0e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55929730 |
swolchok
added a commit
that referenced
this pull request
Apr 9, 2024
It is supposed to be unlikely for assert/check conditions to fail; let's tell the compiler about that. Differential Revision: [D55929730](https://our.internmc.facebook.com/intern/diff/D55929730/) ghstack-source-id: 221859993 Pull Request resolved: #2949
mergennachin
approved these changes
Apr 9, 2024
|
This pull request has been merged in 6cb6051. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
It is supposed to be unlikely for assert/check conditions to fail; let's tell the compiler about that.
Differential Revision: D55929730