Skip to content

[Ez] Fix vulkan_backend linking in Android demo app #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Apr 5, 2024

Stack from ghstack (oldest at bottom):

Context

Fix how vulkan_backend gets linked to the LLaMa demo app JNI.

Differential Revision: D55805378

Copy link

pytorch-bot bot commented Apr 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2872

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a99cc22 with merge base a51b07d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SS-JIA added a commit that referenced this pull request Apr 5, 2024
ghstack-source-id: bf8ae7d
Pull Request resolved: #2872
@pytorch-bot pytorch-bot bot added ciflow/periodic module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ labels Apr 5, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 5, 2024
Copy link

pytorch-bot bot commented Apr 5, 2024

Warning: Unknown label ciflow/periodic.
Currently recognized labels are

  • ciflow/nightly
  • ciflow/trunk
  • ciflow/binaries
  • ciflow/binaries/all

Please add the new label to .github/pytorch-probot.yml

@SS-JIA SS-JIA requested a review from kirklandsign April 5, 2024 16:20
@SS-JIA
Copy link
Contributor Author

SS-JIA commented Apr 5, 2024

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SS-JIA merged this pull request in cc9a715.

@SS-JIA SS-JIA deleted the gh/SS-JIA/29/head branch January 24, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants