Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-ONLY CHANGES] Update release/0.2 to pin and test against PyTorch release/2.3 #2818

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Apr 2, 2024

  • CI: Pin to latest commit in release/2.3 (somehow directly pinning release/2.3 doesn't work)
  • DevX: Update install_requirements.sh to install prebuilt torch-2.3 and torchvision/torchaudio.
  • Fix ExecuTorch downstream to use the old API

Copy link

pytorch-bot bot commented Apr 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2818

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 2a2df5e with merge base e5a8de0 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2024
@guangy10 guangy10 requested review from kit1980 and huydhn April 2, 2024 23:20

# The pip repository that hosts nightly torch packages.
TORCH_NIGHTLY_URL="https://download.pytorch.org/whl/nightly/cpu"
TORCH_URL="https://download.pytorch.org/whl/test/cpu"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if this will be the final url to fetch torch2.3? Maybe it's where RCs are, but not for the final release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the RCs are there on that link. Once it's promoted to prod, the final prod binary will come from https://download.pytorch.org/whl/cpu or PyPI

@guangy10 guangy10 force-pushed the release_compatibility branch 9 times, most recently from 3dfbbc0 to e4961fd Compare April 3, 2024 06:59
@@ -19,4 +21,7 @@ pip install bitsandbytes -I
# For example, torch version required from llava is older than ExecuTorch.
# To make both work, recover ExecuTorch's original dependencies by rerunning
# the install_requirements.sh.
./install_requirements.sh
pip install --force-reinstall torch==2.3.0 --index-url https://download.pytorch.org/whl/test/cpu
Copy link
Contributor

@huydhn huydhn Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my investigation in T184361451, I think we should avoid using -I as in pip install bitsandbytes -I as it seems to confuse pip list

pip install --force-reinstall torch==2.3.0 --index-url https://download.pytorch.org/whl/test/cpu

echo "Finished installing llava dependencies."
pip list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a python -c 'import torch; print(torch.__version__)' to confirm the torch version in used here? I'm curious

Copy link
Contributor

@huydhn huydhn Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe python -c 'import torchvision; print(torchvision.__version__)' and python -c 'import torchaudio; print(torchaudio.__version__)' too. From what I try to reproduce locally, their versions looks correct (trying on ET main)

(executorch) [huydo@devgpu018.odn1 ~/local/github/executorch (main)]$ python -c 'import torchvision; print(torchvision.__version__)'
0.19.0.dev20240324+cpu
(executorch) [huydo@devgpu018.odn1 ~/local/github/executorch (main)]$ python -c 'import torchaudio; print(torchaudio.__version__)'
2.2.0.dev20240324+cpu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the debug log and removed -I. However, I don't even see torch version = is printed hmm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see it in the log though, i.e. https://github.com/pytorch/executorch/actions/runs/8542428080/job/23404038664?pr=2818#step:11:6208

Okay, now I can see the version seems correct now and the job is going further, though it fails the failure is due to memory limits. I think Martin was asking about this in a thread and there is solution for it?

@guangy10
Copy link
Contributor Author

guangy10 commented Apr 5, 2024

Will deal with T184361451 later.

@guangy10
Copy link
Contributor Author

guangy10 commented Apr 5, 2024

Updated third-party/pytorch to point to release/2.3, otherwise build from source will use the wrong version of torch.

@guangy10
Copy link
Contributor Author

guangy10 commented Apr 5, 2024

test-demo-ios / macos-job is flaky in all branches, it's irrelevant to this PR and the issue is tracked in #2877

@guangy10 guangy10 merged commit b31f5ff into release/0.2 Apr 5, 2024
90 of 92 checks passed
guangy10 added a commit that referenced this pull request Apr 5, 2024
guangy10 added a commit that referenced this pull request Apr 6, 2024
mergennachin pushed a commit that referenced this pull request Apr 8, 2024
@mergennachin mergennachin mentioned this pull request Apr 25, 2024
@guangy10 guangy10 deleted the release_compatibility branch August 21, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants