add aten.sum.default #2807
Closed
add aten.sum.default #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2807
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 79943ca with merge base 564c276 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55630993 |
copyrightly
added a commit
to copyrightly/executorch
that referenced
this pull request
Apr 2, 2024
Summary: The operator `aten.sum.dim_IntList` could take an empty list as the parameter for `dims`. We modify `vulkan_graph_builder.py` to accommodate the empty list. Moreover, the op `aten.sum.default` is implemented as a [decomposition](https://www.internalfb.com/code/fbsource/[96e496f9db8f92967b4394bd4f60e39ab916740b]/xplat/caffe2/torch/_decomp/decompositions.py?lines=4676) into `aten.sum.dim_IntList` with empty `dims`. So we will support `aten.sum.default` with the changes. Context: `torch.sum(x, ())` and `torch.sum(x)` are two ways to compute the sum of all elements in tensor `x`. Differential Revision: D55630993
copyrightly
force-pushed
the
export-D55630993
branch
from
c909050
to
b551ec4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55630993 |
SS-JIA
approved these changes
Apr 2, 2024
Summary: The operator `aten.sum.dim_IntList` could take an empty list as the parameter for `dims`. We modify `vulkan_graph_builder.py` to accommodate the empty list. Moreover, the op `aten.sum.default` is implemented as a [decomposition](https://www.internalfb.com/code/fbsource/[96e496f9db8f92967b4394bd4f60e39ab916740b]/xplat/caffe2/torch/_decomp/decompositions.py?lines=4676) into `aten.sum.dim_IntList` with empty `dims`. So we will support `aten.sum.default` with the changes. Context: `torch.sum(x, ())` and `torch.sum(x)` are two ways to compute the sum of all elements in tensor `x`. Reviewed By: SS-JIA, jorgep31415 Differential Revision: D55630993
copyrightly
force-pushed
the
export-D55630993
branch
from
b551ec4
to
79943ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55630993 |
|
This pull request has been merged in b145701. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The operator
aten.sum.dim_IntListcould take an empty list as the parameter fordims. We modifyvulkan_graph_builder.pyto accommodate the empty list.Moreover, the op
aten.sum.defaultis implemented as a decomposition intoaten.sum.dim_IntListwith emptydims. So we will supportaten.sum.defaultwith the changes.Context:
torch.sum(x, ())andtorch.sum(x)are two ways to compute the sum of all elements in tensorx.Differential Revision: D55630993