Rewrite Index Op #278
Closed
Rewrite Index Op #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D49159987 fbshipit-source-id: cce3b28b2ae7a354e1aded8c0f1810f4909bc2f3
Summary: Full rewrite of index op, so that it completely implements numpy's [advanced indexing](https://numpy.org/doc/stable/user/basics.indexing.html#advanced-indexing) functionality. Reviewed By: kirklandsign Differential Revision: D49159988 fbshipit-source-id: 1ddd8333dfbd0c1eb8e572d361c4c15df3d43cec
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49159988 |
|
This pull request has been merged in 7692b51. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Full rewrite of index op, so that it completely implements numpy's advanced indexing functionality.
Reviewed By: kirklandsign
Differential Revision: D49159988