Skip to content

[executorch][muse] Hash prepared image identity without CommonCrypto - #24006

Merged
Gasoonjia merged 1 commit into
gh/Gasoonjia/45/origfrom
gh/Gasoonjia/46/orig
Oct 20, 2026
Merged

Gasoonjia merged 1 commit into
gh/Gasoonjia/45/origfrom
gh/Gasoonjia/46/orig

Conversation

@Gasoonjia

Copy link
Copy Markdown
Contributor

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #23730 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/46/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/46/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/45/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/46/orig
Differential Revision: D124871958
@diff-train-skip-merge

Pull Request resolved: #23730

The MG prompt preparer hashes canonical RGB, dimensions and vision-grid metadata into a SHA-256 image-prefix identity. Select the implementation with the existing build macros: MLX/macOS uses CommonCrypto, while CUDA compiles the existing portable FIPS 180-4 implementation and has no platform crypto dependency.

Keep the hashed bytes, their order and the 32-byte digest unchanged across implementations. The fixed canonical-image digest fixture continues to pin image-prefix identity. No additional hashing library is introduced.
ghstack-source-id: 451855083
@exported-using-ghexport

Differential Revision: [D124871958](https://our.internmc.facebook.com/intern/diff/D124871958/)
@pytorch-bot

pytorch-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24006

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 188 Pending

As of commit 0e1890e with merge base 897d28f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2026
@Gasoonjia
Gasoonjia added this pull request to stack #24012 October 20, 2026 03:42
@Gasoonjia
Gasoonjia merged commit 5f41467 into main Oct 20, 2026
263 of 272 checks passed
@Gasoonjia
Gasoonjia deleted the gh/Gasoonjia/46/orig branch October 20, 2026 03:43

This branch was successfully deployed

1 active deployment
cadence — 0e1890e0 Deployed Oct 20, 2026 by Gasoonjia via hifi-op-test / hifi4 #34138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants