Arm backend: Support boolean attention mask#17734
Arm backend: Support boolean attention mask#17734YufengShi-dudu wants to merge 1 commit intopytorch:mainfrom
Conversation
- TOSA bitwise_* does not accept boolean inputs; attention masks often apply boolean bitwise operators that are equivalent to logical_*. - Rename and extend RewriteBoolBitwiseNotToLogicalNotPass to RewriteBoolBitwiseToLogicalPass so bool bitwise_not/and/or/xor are rewritten to the corresponding aten.logical_* ops. - Update and correct bitwise operator tests for bool inputs. Change-Id: I5532f297587915d99213b8e597942fcc756ca7de Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17734
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Cancelled JobsAs of commit 5c2b5d0 with merge base 331ac4a ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@zingo I don't have the permission to add labels and run trunks now. |
TOSA bitwise_* does not accept boolean inputs; attention masks often apply boolean bitwise operators that are equivalent to logical_*.
Rename and extend RewriteBoolBitwiseNotToLogicalNotPass to RewriteBoolBitwiseToLogicalPass so bool bitwise_not/and/or/xor are rewritten to the corresponding aten.logical_* ops.
Update and correct bitwise operator tests for bool inputs.
Change-Id: I5532f297587915d99213b8e597942fcc756ca7de
cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell