Update HiFi1 to use nnlib

[mcremon-meta]

Summary:
As titled. Was falling back on xtensa.
Adds a few fixes to some operators to enable the build for all cases.

Differential Revision: D94179206

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17676

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 8c489a0 with merge base 7cdd975 ():

NEW FAILURES - The following jobs have failed:

• pull / test-mediatek-models-linux / linux-job (gh)
  RuntimeError: Command docker exec -t bb7afa052cd560cf37c78a1684ea47f2c2ef43d6530a26c0716acfe2dea7ed7d /exec failed with exit code 2
• pull / test-openvino-linux / linux-job (gh)
  RuntimeError: Command docker exec -t 1b4cf4129536f9b9c7de07ee8ec24b23fb32f1bae911636b614fbee0b736bec6 /exec failed with exit code 1
• pull / unittest-arm-backend-with-no-deps (test_pytest_ops_tosa) / linux-job (gh)
  RuntimeError: Command docker exec -t e0538ad469b2bea73d8ee437d3407a065dc7eadf9730e12193c36f8708048d89 /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[meta-codesync]

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94179206.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[mcremon-meta]

@dijopaul @cad-audio can you take a look please? :)

[dijopaul]

I think this is not needed. Can remove this line
xtbool2 con = int32_rtor_xtbool2(0x00000003);
the vaiable not used

[dijopaul]

Can use the below code

#ifndef AE_MOVAB
#ifdef AE_MOVAB1
#define AE_MOVAB AE_MOVAB1
#else
#define AE_MOVAB(x) (x)
#endif
#endif

#ifndef AE_MOVAB2
#define AE_MOVAB2(x) (x)
#endif

[dijopaul]

@dijopaul @cad-audio can you take a look please? :)

The root cause here is that we are using local implementations outside nnlib (which is hifi4 specific). The latest nnlib has all these implementation inside including hifi1 support. So better solution is to upgrade to latest nnlib and avoid these local files. We will make a PR for the same. This may involve some changes in API calls as well due to minor changes in API names.