NXP backend: added support for aten.bmm#17670
NXP backend: added support for aten.bmm#17670novak-vaclav wants to merge 1 commit intopytorch:mainfrom
aten.bmm#17670Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17670
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit 5035fec with merge base 746db5f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: nxp" |
f7f1d02 to
88aab65
Compare
|
@pytorchbot label "module: nxp" |
|
In the last force-push, I just added the brief operator support description to |
There was a problem hiding this comment.
Pull request overview
Adds NXP backend support for the aten.bmm operator by introducing a new IR converter and quantization pattern, updating delegation maps, and adding basic converter tests and documentation.
Changes:
- Register
aten.bmmfor delegation and conversion (partitioner + EdgeProgram IR converter). - Add
BMMConverter(TFLiteBatchMatMul) andBMMPatternfor quantization annotation. - Add
bmmtest models + a new node-converter test module; update NXP op-support docs.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/source/backends/nxp/op-support.csv | Documents aten.bmm.default support and target constraints. |
| backends/nxp/tests/models.py | Adds simple modules exercising torch.bmm (including a conv→bmm path). |
| backends/nxp/tests/ir/converter/node_converter/test_bmm_converter.py | Adds conversion/delegation tests for bmm. |
| backends/nxp/quantizer/patterns.py | Introduces BMMPattern to annotate bmm quantization behavior. |
| backends/nxp/quantizer/neutron_quantizer.py | Registers BMMPattern in the quantizer op list. |
| backends/nxp/neutron_partitioner.py | Adds aten.bmm → BMMConverter mapping for partitioning. |
| backends/nxp/backend/ir/converter/node_converters/ops_converters/bmm_converter.py | Implements aten.bmm → TFLite BatchMatMul conversion. |
| backends/nxp/backend/ir/converter/node_converters/ops_converters/init.py | Exports BMMConverter. |
| backends/nxp/backend/edge_program_converter.py | Adds aten.bmm → BMMConverter mapping for program conversion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
backends/nxp/backend/ir/converter/node_converters/ops_converters/bmm_converter.py
Show resolved
Hide resolved
88aab65 to
5035fec
Compare
Summary
adds support for
aten.bmmoperatorTest plan
tests can be manually run using
pytest -c /dev/null backends/nxp/tests/cc @robert-kalmar @JakeStevens @digantdesai @roman-janik-nxp @MartinPavella @StrycekSimon @jirioc