Skip to content

NXP backend: added support for aten.bmm#17670

Open
novak-vaclav wants to merge 1 commit intopytorch:mainfrom
nxp-upstream:feature/EIEX-709-add-support-for-aten-bmm
Open

NXP backend: added support for aten.bmm#17670
novak-vaclav wants to merge 1 commit intopytorch:mainfrom
nxp-upstream:feature/EIEX-709-add-support-for-aten-bmm

Conversation

@novak-vaclav
Copy link
Contributor

Summary

adds support for aten.bmm operator

Test plan

tests can be manually run using pytest -c /dev/null backends/nxp/tests/

cc @robert-kalmar @JakeStevens @digantdesai @roman-janik-nxp @MartinPavella @StrycekSimon @jirioc

Copilot AI review requested due to automatic review settings February 24, 2026 13:04
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 24, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17670

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 5035fec with merge base 746db5f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 24, 2026
@novak-vaclav
Copy link
Contributor Author

@pytorchbot label "release notes: nxp"

@pytorch-bot pytorch-bot bot added the release notes: nxp Changes to the NXP Neutron backend delegate label Feb 24, 2026
@MartinPavella MartinPavella requested review from MartinPavella and removed request for Copilot February 24, 2026 13:06
@novak-vaclav novak-vaclav force-pushed the feature/EIEX-709-add-support-for-aten-bmm branch from f7f1d02 to 88aab65 Compare February 24, 2026 13:29
Copilot AI review requested due to automatic review settings February 24, 2026 13:29
@novak-vaclav
Copy link
Contributor Author

@pytorchbot label "module: nxp"

@pytorch-bot pytorch-bot bot added the module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ label Feb 24, 2026
@novak-vaclav
Copy link
Contributor Author

In the last force-push, I just added the brief operator support description to op-support.csv

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds NXP backend support for the aten.bmm operator by introducing a new IR converter and quantization pattern, updating delegation maps, and adding basic converter tests and documentation.

Changes:

  • Register aten.bmm for delegation and conversion (partitioner + EdgeProgram IR converter).
  • Add BMMConverter (TFLite BatchMatMul) and BMMPattern for quantization annotation.
  • Add bmm test models + a new node-converter test module; update NXP op-support docs.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/source/backends/nxp/op-support.csv Documents aten.bmm.default support and target constraints.
backends/nxp/tests/models.py Adds simple modules exercising torch.bmm (including a conv→bmm path).
backends/nxp/tests/ir/converter/node_converter/test_bmm_converter.py Adds conversion/delegation tests for bmm.
backends/nxp/quantizer/patterns.py Introduces BMMPattern to annotate bmm quantization behavior.
backends/nxp/quantizer/neutron_quantizer.py Registers BMMPattern in the quantizer op list.
backends/nxp/neutron_partitioner.py Adds aten.bmmBMMConverter mapping for partitioning.
backends/nxp/backend/ir/converter/node_converters/ops_converters/bmm_converter.py Implements aten.bmm → TFLite BatchMatMul conversion.
backends/nxp/backend/ir/converter/node_converters/ops_converters/init.py Exports BMMConverter.
backends/nxp/backend/edge_program_converter.py Adds aten.bmmBMMConverter mapping for program conversion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@novak-vaclav novak-vaclav force-pushed the feature/EIEX-709-add-support-for-aten-bmm branch from 88aab65 to 5035fec Compare February 24, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants