Move output tensor resize to before XNNPACK subgraph execution

[GregoryComer]

Summary:
ET's XNNPACK delegate currently resizes output tensors after running the XNNPACK subgraph. This is normally fine, as the buffer is large enough. However, if there is a logic bug or corrupt model file, the current code doesn't catch if XNNPACK's output is larger than the planned buffer until after execution, where it may crash.

To fix this, I've moved the resize up. This fails gracefully in the above case.

Differential Revision: D94148443

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17661

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 5 Unrelated Failures

As of commit 45ee5c1 with merge base 3319157 ():

NEW FAILURES - The following jobs have failed:

• pull / test-samsung-models-linux / linux-job (gh)
  RuntimeError: Command docker exec -t 2602c07838939764af82975238761de492b113e2c8f0d9ea573f2983e99e9bd4 /exec failed with exit code 1
• pull / test-samsung-quantmodels-linux / linux-job (gh)
  RuntimeError: Command docker exec -t 11cfc633cbae71d1992caae168298e8fc6d3a144571cea062292c82168b4a4c2 /exec failed with exit code 1
• pull / unittest / macos / macos-job (gh)
  export/tests/test_target_recipes.py::TestTargetRecipes::test_linear_model
• pull / unittest-arm-backend-with-no-deps (test_pytest_ops_no_target) / linux-job (gh)
  RuntimeError: Command docker exec -t 8d58dda521d8d0bcd382a46366a6e11539b424da14873caf25691e3d604c96e3 /exec failed with exit code 1
• Test CUDA Builds / test-models-cuda (linear) / linux-job (gh)
  RuntimeError: Command docker exec -t a9598ca422cb09b40002e03b6df68c16876951cfcd9fe1fe461d6398330fc25d /exec failed with exit code 1

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• pull / test-qnn-models-linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
• pull / test-selective-build-linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
• pull / test-setup-linux-gcc / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
• pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
• pull / unittest-arm-backend-with-no-deps (test_pytest_ops_tosa) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[meta-codesync]

@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94148443.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.