Skip to content

Error out if git symlink not enabled on Windows #15684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −1
Open

Error out if git symlink not enabled on Windows #15684

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca31e4c
Fix windows build cannot find versions.py
larryliu0820 Nov 7, 2025
2ebc280
Exit if symlink is not enabled on Windows
larryliu0820 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,9 @@ def run(self):
dst_root = self.get_package_dir(".")
else:
dst_root = os.path.join(self.build_lib, "executorch")
# On Windows the package directory might not exist yet when building from a
# clean tree. Ensure it is created before we attempt to write version.py.
self.mkpath(dst_root)
# Create the version file.
Version.write_to_python_file(os.path.join(dst_root, "version.py"))

Expand Down
Loading