Manually cherry-pick "Pin huggingface_hub<1.0" #15667
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to fix failing HF CI jobs. Looks like our transformers version requires huggingface_hub<1.0, but we're installing the latest 1.0 version which just released today. Until we bump transformers, I'll just pin our install of huggingface_hub to below 1.0. Note that we don't pin the transformers version the same way for pip install, so this should be a ci only issue (and hence ci only fix). Here's an example job failure: ``` transformers 4.56.1 requires huggingface-hub<1.0,>=0.34.0, but you have huggingface-hub 1.0.0 which is incompatible. ... /exec: line 13: huggingface-cli: command not found ``` (from https://github.com/pytorch/executorch/actions/runs/18851188516/job/53787937311) (cherry picked from commit 57f0dfd)
We need to pin huggingface_hub in CI to avoid an incompatibility with our pinned version of transformers. See pytorch#15399 for more context - I missed a few places on trunk jobs. Cleaning these up here. Running with ciflow/trunk. I verified that the test-huggingface-transformers-macos / * and gemma3-4b macos jobs pass on this PR. They are failing on trunk (see https://hud.pytorch.org/pytorch/executorch/commit/4c30da308ee811bdfa44fd4bea3bc439bfd303d4 for an example).
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15667
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 4 Cancelled JobsAs of commit 0d6ebe2 with merge base e0dda90 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
GregoryComer
added
ciflow/trunk
release notes: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a manual cherry-pick of #15399 and #15403 to resolve CI failures caused by an incompatibility between the newly released huggingface_hub package and our pinned version of transformers. Due to differences between main and release/1.0, the automated cherry-pick failed, so I've reverted to a manual pick and some small manual edits to examples/models/llama/install_requirements.sh.
Test Plan
This PR is running trunk CI.