Skip to content

Conversation

@ArmRyan
Copy link
Collaborator

@ArmRyan ArmRyan commented Nov 5, 2025

  • Only affects models >2gb

Change-Id: Id5ec79eecc4f1ae8d864e35ed13b34bbf761d30b

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

 * Only affects models >2gb

Signed-off-by: Ryan O'Shea <ryan.oshea3@arm.com>
Change-Id: Id5ec79eecc4f1ae8d864e35ed13b34bbf761d30b
@ArmRyan ArmRyan requested review from YufengShi-dudu and per November 5, 2025 11:40
@ArmRyan ArmRyan requested a review from digantdesai as a code owner November 5, 2025 11:40
@ArmRyan ArmRyan added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Nov 5, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15592

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 6 Unrelated Failures

As of commit 9650adc with merge base 964515c (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2025
@zingo
Copy link
Collaborator

zingo commented Nov 5, 2025

@SS-JIA here is a change bumping TOSA slightly that you might also want to test, we think it will work if you keep the old version internally if you prefer, this change should only be needed on larger models that are not yet in the tests flow.

@ArmRyan
Copy link
Collaborator Author

ArmRyan commented Nov 5, 2025

@SS-JIA here is a change bumping TOSA slighly that you might also wen to test, we also think to will work if you keep the old version internally, this change should only be needed on larger models that are not yet in the tests flow.

This is just a 2line change in an existing function it doesnt add anything new or change any behaviour, it just resereves memory correctly so nothing changes functionally and no new files or structure changes - wont affect anything

Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been tested internally and shows a significant speedup on large models.

@zingo zingo merged commit 149e23d into pytorch:main Nov 5, 2025
297 of 306 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Nov 6, 2025
…#15592)

* Only affects models >2gb

Signed-off-by: Ryan O'Shea <ryan.oshea3@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants