-
Notifications
You must be signed in to change notification settings - Fork 712
Arm backend: Cherry-pick tosa patch to speed up large models #15592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Cherry-pick tosa patch to speed up large models #15592
Conversation
* Only affects models >2gb Signed-off-by: Ryan O'Shea <ryan.oshea3@arm.com> Change-Id: Id5ec79eecc4f1ae8d864e35ed13b34bbf761d30b
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15592
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 6 Unrelated FailuresAs of commit 9650adc with merge base 964515c ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@SS-JIA here is a change bumping TOSA slightly that you might also want to test, we think it will work if you keep the old version internally if you prefer, this change should only be needed on larger models that are not yet in the tests flow. |
This is just a 2line change in an existing function it doesnt add anything new or change any behaviour, it just resereves memory correctly so nothing changes functionally and no new files or structure changes - wont affect anything |
YufengShi-dudu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been tested internally and shows a significant speedup on large models.
…#15592) * Only affects models >2gb Signed-off-by: Ryan O'Shea <ryan.oshea3@arm.com>
Change-Id: Id5ec79eecc4f1ae8d864e35ed13b34bbf761d30b
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai