-
Notifications
You must be signed in to change notification settings - Fork 715
More overflow checks in memory allocator. #15581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15581
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (6 Unrelated Failures)As of commit c325d75 with merge base 149e23d ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86228757. |
This PR needs a
|
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Differential Revision: D86228757
3f70d29 to
e768e68
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Differential Revision: D86228757
e768e68 to
1378480
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Differential Revision: D86228757
1378480 to
561d529
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Reviewed By: JacobSzwejbka Differential Revision: D86228757
561d529 to
9d9373b
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Reviewed By: JacobSzwejbka Differential Revision: D86228757
9d9373b to
cf29988
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Reviewed By: JacobSzwejbka Differential Revision: D86228757
cf29988 to
fef12c8
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Reviewed By: JacobSzwejbka Differential Revision: D86228757
fef12c8 to
ceb27a6
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Reviewed By: JacobSzwejbka Differential Revision: D86228757
ceb27a6 to
b82e67f
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Reviewed By: JacobSzwejbka Differential Revision: D86228757
b82e67f to
ea5e729
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Reviewed By: JacobSzwejbka Differential Revision: D86228757
ea5e729 to
6eb8a45
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Reviewed By: JacobSzwejbka Differential Revision: D86228757
6eb8a45 to
6971f50
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Reviewed By: JacobSzwejbka Differential Revision: D86228757
6971f50 to
c325d75
Compare
Summary: - Safer overflow math for high alignments - Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested - Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size Differential Revision: D86228757
Summary:
Differential Revision: D86228757