Skip to content

Conversation

@shoumikhin
Copy link
Contributor

Summary:

  • Safer overflow math for high alignments
  • Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
  • Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Differential Revision: D86228757

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15581

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit c325d75 with merge base 149e23d (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 4, 2025

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86228757.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 4, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 4, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 4, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 5, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Reviewed By: JacobSzwejbka

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 5, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Reviewed By: JacobSzwejbka

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 5, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Reviewed By: JacobSzwejbka

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 5, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Reviewed By: JacobSzwejbka

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 5, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Reviewed By: JacobSzwejbka

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 5, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Reviewed By: JacobSzwejbka

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 5, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Reviewed By: JacobSzwejbka

Differential Revision: D86228757
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Nov 5, 2025
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Reviewed By: JacobSzwejbka

Differential Revision: D86228757
Summary:

- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and use the final size

Reviewed By: JacobSzwejbka

Differential Revision: D86228757
@shoumikhin shoumikhin merged commit 6b545a2 into pytorch:main Nov 5, 2025
434 of 443 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Nov 6, 2025
Summary:
- Safer overflow math for high alignments
- Only over-allocate up to alignment - 1 bytes when a higher-than-malloc
alignment is requested
- Move EXECUTORCH_TRACK_ALLOCATION to after a successful allocation and
use the final size

Differential Revision: D86228757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants