Skip to content

Conversation

@SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented Nov 3, 2025

Summary

Updates to operators for int16:

  • avg_pool2d, clamp, constant_pad_nd, eq, ge, gt, le, lt, max_pool2d, upsample_bilinear, upsample_nearest2d

Test plan

Unit tests added for affected operators

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

* Update test infra to handle int16x8

Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
@SaoirseARM SaoirseARM requested a review from zingo November 3, 2025 12:06
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15521

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 6 Unrelated Failures

As of commit 70e5200 with merge base 964515c (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Nov 3, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Nov 3, 2025
@zingo
Copy link
Collaborator

zingo commented Nov 3, 2025

@SS-JIA thanks for the help with all the larger patches, here is another one for you, that I also think should be buck2 fine but better to doublecheck :)

@zingo
Copy link
Collaborator

zingo commented Nov 4, 2025

@SaoirseARM has an arm fail and needs a rebase, lets see if the rebase fixes the fails :)

SaoirseARM and others added 2 commits November 5, 2025 10:59
Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
@Ninja91
Copy link
Contributor

Ninja91 commented Nov 5, 2025

Thanks for adding these set of ops with 16a8w for U55/U85

@SS-JIA
Copy link
Contributor

SS-JIA commented Nov 5, 2025

Sorry just seeing this one, will try to import this internally since it is a bigger change!

@Ninja91 Ninja91 self-requested a review November 6, 2025 09:01
Copy link
Contributor

@Ninja91 Ninja91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SS-JIA SS-JIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be okay

@zingo
Copy link
Collaborator

zingo commented Nov 7, 2025

Testa are unrelated

@zingo zingo merged commit 80c9040 into pytorch:main Nov 7, 2025
288 of 295 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants