Fix missing enum values in switch statements #15515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSProgrammer
requested review from
JacobSzwejbka,
lucylq and
shoumikhin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15515
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 70 PendingAs of commit 4c2164c with merge base 73b6918 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@NSProgrammer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85956878. |
Contributor
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
NSProgrammer
force-pushed
the
export-D85956878
branch
from
8cc59c4 to
47e1668
Compare
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
47e1668 to
b614817
Compare
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Differential Revision: D85956878
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
b614817 to
1fadfda
Compare
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
1fadfda to
92b289b
Compare
shoumikhin
approved these changes
Nov 3, 2025
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Reviewed By: shoumikhin Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
92b289b to
f5b98bf
Compare
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Reviewed By: shoumikhin Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
f5b98bf to
02ca6ac
Compare
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Reviewed By: shoumikhin Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
02ca6ac to
224cfad
Compare
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Reviewed By: shoumikhin Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
224cfad to
d5b7f40
Compare
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Reviewed By: shoumikhin Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
d5b7f40 to
ddd955f
Compare
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Reviewed By: shoumikhin Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
ddd955f to
475c363
Compare
NSProgrammer
added a commit
to NSProgrammer/executorch
that referenced
this pull request
Nov 3, 2025
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Reviewed By: shoumikhin Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
475c363 to
bad291a
Compare
) Summary: `-Wswitch-enum` was introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even with `default:` present. This helps alert developers when they add an enum value of all the switch statements that need updating. These diffs are to help progress the codebase so that we can enable `-Wswitch-enum` by default in `fbobjc` Reviewed By: shoumikhin Differential Revision: D85956878
NSProgrammer
force-pushed
the
export-D85956878
branch
from
bad291a to
2c7492e
Compare
abhinaykukkadapu
pushed a commit
to abhinaykukkadapu/executorch
that referenced
this pull request
Nov 6, 2025
Differential Revision: D85956878 Pull Request resolved: pytorch#15515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
-Wswitch-enumwas introduced in 2024 and is beneficial because it will err when switch statement is missing a case for an enum, even withdefault:present. This helps alert developers when they add an enum value of all the switch statements that need updating.These diffs are to help progress the codebase so that we can enable
-Wswitch-enumby default infbobjcDifferential Revision: D85956878