-
Notifications
You must be signed in to change notification settings - Fork 722
Use -O2 compilation for Autocorrect only #15425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15425
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 10 New FailuresAs of commit 8f66a03 with merge base 7741e70 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Summary: Apply -02 compiler flag to make FLLM autocorrect faster Sheet measuring different scopes of applying -02 and the resulting latency https://docs.google.com/spreadsheets/d/1ZnxoRwCIiMz3hXyhgb6sm_2UThBUyq-mpp8RzksfJMQ/edit?usp=sharing Differential Revision: D85152814
f4f7392 to
8f66a03
Compare
|
Hi @Camyll! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
| # Add -O2 compiler flag when the compiler_flag_O2 config is set | ||
| kwargs["compiler_flags"] = kwargs["compiler_flags"] + select({ | ||
| "DEFAULT": [], | ||
| "fbsource//xplat/assistant/oacr/native/scripts:compiler_flag_O2": ["-O2"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmn, not seeing this be commented out. It should look like the examples on line 102-112, or this: #15582
Summary: Apply -02 compiler flag to make FLLM autocorrect faster Sheet measuring different scopes of applying -02 and the resulting latency https://docs.google.com/spreadsheets/d/1ZnxoRwCIiMz3hXyhgb6sm_2UThBUyq-mpp8RzksfJMQ/edit?usp=sharing ****Latency**** Reviewed By: BlakeLucchesi Differential Revision: D85152814
|
Closing as duplicate of #15583 |
Differential Revision: D85152814 Pull Request resolved: #15583
Differential Revision: D85152814 Pull Request resolved: pytorch#15583
Summary:
Apply -02 compiler flag to make FLLM autocorrect faster
Sheet measuring different scopes of applying -02 and the resulting latency
https://docs.google.com/spreadsheets/d/1ZnxoRwCIiMz3hXyhgb6sm_2UThBUyq-mpp8RzksfJMQ/edit?usp=sharing
Differential Revision: D85152814