Skip to content

Conversation

@3l1
Copy link
Contributor

@3l1 3l1 commented Oct 3, 2025

Summary:
Fix Rsqrt op for int16
Add unit tests

Differential Revision: D83802158

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@3l1 3l1 requested a review from digantdesai as a code owner October 3, 2025 03:59
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14770

Note: Links to docs will display an error until the docs builds have been completed.

❌ 18 New Failures, 3 Unrelated Failures

As of commit e4569d6 with merge base 331d771 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2025
@facebook-github-bot
Copy link
Contributor

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83802158.

@3l1
Copy link
Contributor Author

3l1 commented Oct 3, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Oct 3, 2025
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable just the tests?

facebook-github-bot pushed a commit that referenced this pull request Oct 10, 2025
Summary:

Fix Rsqrt op for int16
Add unit tests

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: digantdesai

Differential Revision: D83802158
@meta-codesync
Copy link

meta-codesync bot commented Oct 10, 2025

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83802158.

3l1 added a commit that referenced this pull request Oct 22, 2025
Summary:
Pull Request resolved: #14770

Fix Rsqrt op for int16
Add unit tests

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D83802158
@3l1 3l1 force-pushed the export-D83802158 branch from 732b518 to 24c28e1 Compare October 22, 2025 18:24
3l1 added a commit that referenced this pull request Oct 22, 2025
Summary:
Pull Request resolved: #14770

Fix Rsqrt op for int16
Add unit tests

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D83802158
@3l1 3l1 force-pushed the export-D83802158 branch from 24c28e1 to 3a754b3 Compare October 22, 2025 18:35
Summary:

Fix Rsqrt op for int16
Add unit tests

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D83802158
facebook-github-bot pushed a commit that referenced this pull request Oct 27, 2025
Summary:

Fix Rsqrt op for int16

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D83802158
@zingo zingo added module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Nov 6, 2025
@zingo zingo changed the title Enable int16 rsqrt on Ethos-U55/U85 Arm backend: Enable int16 rsqrt on Ethos-U55/U85 Nov 6, 2025
@zingo
Copy link
Collaborator

zingo commented Nov 7, 2025

I see this errors
pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (pull_request)

FAILED backends/arm/test/ops/test_rsqrt.py::test_rsqrt_int16_tosa_INT[rand_4d_1]
FAILED backends/arm/test/ops/test_rsqrt.py::test_rsqrt_int16_tosa_INT[rand_4d_2]

@3l1 could they be caused by the PR?
As they will break the CI they need to be addressed before merging.

@zingo
Copy link
Collaborator

zingo commented Nov 7, 2025

Replaced by #15631

@zingo zingo closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants