NXP backend: Use zero point for quantized padding. #13576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13576
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 PendingAs of commit 54ef48c with merge base c70aeda ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "module: nxp" "release notes: nxp" |
pytorch-bot
bot
added
module: nxp
JakeStevens
approved these changes
Aug 21, 2025
| # be included in the computation! | ||
| input_quantization = t_op.tmp_inputs[0].quantization | ||
| pad_value = ( | ||
| None |
Contributor
There was a problem hiding this comment.
Why None instead of 0 in non quantized?
Collaborator
Author
There was a problem hiding this comment.
None is the default value of the builder.create_pad_operator_before() method's constant_value parameter. This way, the actual default padding value (0) is only defined in 1 place.
But it's hard to image that the default padding value would ever be changed, and using 0 here would make the code more understandable. I have no problem using 0 instead of None if you prefer.
MartinPavella
force-pushed
the
upstream/main-nxp/EIEX-497-upstream-padding-with-zero_point
branch
from
0f68cd2 to
52d6c1b
Compare
MartinPavella
force-pushed
the
upstream/main-nxp/EIEX-497-upstream-padding-with-zero_point
branch
from
52d6c1b to
54ef48c
Compare
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
### Summary This PR fixes cases where padding with the value `0` was used for quantized operators. Now, zero point is used instead. ### Test plan Unit tests provided. cc @digantdesai @JakeStevens @robert-kalmar
kimishpatel
pushed a commit
that referenced
this pull request
Sep 2, 2025
### Summary This PR fixes cases where padding with the value `0` was used for quantized operators. Now, zero point is used instead. ### Test plan Unit tests provided. cc @digantdesai @JakeStevens @robert-kalmar
robert-kalmar
deleted the
upstream/main-nxp/EIEX-497-upstream-padding-with-zero_point
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes cases where padding with the value
0was used for quantized operators. Now, zero point is used instead.Test plan
Unit tests provided.
cc @digantdesai @JakeStevens @robert-kalmar