Wrap LLM runner tests in anonymous namespace (unbreak unittest-release) #13524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
swolchok
requested review from
jackzhxng,
larryliu0820 and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13524
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 20 PendingAs of commit f306001 with merge base cc88b03 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Aug 19, 2025
This prevents our test classes from colliding with other global-namespace classes. The specific cause was MockModule being (apparently) the name of a class in gmock or gtest, but I went ahead and did all the tests in this directory to be safe. ghstack-source-id: d1ae4f0 ghstack-comment-id: 3202073825 Pull-Request: #13524
meta-cla
bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Aug 19, 2025
This prevents our test classes from colliding with other global-namespace classes. The specific cause was MockModule being (apparently) the name of a class in gmock or gtest, but I went ahead and did all the tests in this directory to be safe. ghstack-source-id: fd949c3 ghstack-comment-id: 3202073825 Pull-Request: #13524
mergennachin
approved these changes
Aug 19, 2025
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…e) (pytorch#13524) This prevents our test classes from colliding with other global-namespace classes. The specific cause was MockModule being (apparently) the name of a class in gmock or gtest, but I went ahead and did all the tests in this directory to be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents our test classes from colliding with other global-namespace classes. The specific cause was MockModule being (apparently) the name of a class in gmock or gtest, but I went ahead and did all the tests in this directory to be safe.