Skip to content

Conversation

jackzhxng
Copy link
Contributor

Summary

Improves CI coverage of Optimum in ET:

  • More model coverage
  • Add XNNPack coverage for mac
  • Adds perplexity checks for causal LM tests instead of just printing output
  • Refactors all Optimum CI to use the same testing modules.

Test plan

Run trunk tests

Copy link

pytorch-bot bot commented Aug 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13400

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 9 Pending, 1 Unrelated Failure

As of commit a0c373f with merge base 30a6f5e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2025
@jackzhxng jackzhxng added ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 14, 2025
@jackzhxng jackzhxng force-pushed the jz/optimum-ci-in-et branch from 9f6c79e to 1ee83cb Compare August 14, 2025 00:47
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2025
@jackzhxng jackzhxng force-pushed the jz/optimum-ci-in-et branch 2 times, most recently from c7f00d3 to ce1e8ec Compare August 14, 2025 00:59
@jackzhxng jackzhxng added release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. ciflow/trunk and removed ciflow/trunk labels Aug 14, 2025
@metascroy
Copy link
Contributor

LGTM

"gemma3-1b": (
"unsloth/gemma-3-1b-it",
test_text_generation,
), # does not export for CoreML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, it does not export for portable/xnnpack either unless you swap the SDPA with the custom one.

So I think the export issue is general, not CoreML specific, but using custom SDPA "fixes" the export issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does CoreML use custom sdpa / custom kv cache update?

@jackzhxng jackzhxng force-pushed the jz/optimum-ci-in-et branch 4 times, most recently from c0f00c2 to dab8404 Compare August 14, 2025 07:04
@jackzhxng jackzhxng force-pushed the jz/optimum-ci-in-et branch from dab8404 to 79b2841 Compare August 14, 2025 07:17
@jackzhxng jackzhxng force-pushed the jz/optimum-ci-in-et branch from 095dfb3 to a0c373f Compare August 15, 2025 16:17
@jackzhxng jackzhxng merged commit 2c0752a into main Aug 15, 2025
368 of 383 checks passed
@jackzhxng jackzhxng deleted the jz/optimum-ci-in-et branch August 15, 2025 17:11
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
…#13400)

### Summary
Improves CI coverage of Optimum in ET:
- More model coverage
- Add XNNPack coverage for mac
- Adds perplexity checks for causal LM tests instead of just printing
output
- Refactors all Optimum CI to use the same testing modules.

### Test plan
Run trunk tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants