-
Notifications
You must be signed in to change notification settings - Fork 685
Improve optimum coverage in ET (more models, xnnpack on mac) #13400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13400
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 9 Pending, 1 Unrelated FailureAs of commit a0c373f with merge base 30a6f5e ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
9f6c79e
to
1ee83cb
Compare
c7f00d3
to
ce1e8ec
Compare
LGTM |
"gemma3-1b": ( | ||
"unsloth/gemma-3-1b-it", | ||
test_text_generation, | ||
), # does not export for CoreML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, it does not export for portable/xnnpack either unless you swap the SDPA with the custom one.
So I think the export issue is general, not CoreML specific, but using custom SDPA "fixes" the export issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does CoreML use custom sdpa / custom kv cache update?
c0f00c2
to
dab8404
Compare
dab8404
to
79b2841
Compare
095dfb3
to
a0c373f
Compare
…#13400) ### Summary Improves CI coverage of Optimum in ET: - More model coverage - Add XNNPack coverage for mac - Adds perplexity checks for causal LM tests instead of just printing output - Refactors all Optimum CI to use the same testing modules. ### Test plan Run trunk tests
Summary
Improves CI coverage of Optimum in ET:
Test plan
Run trunk tests