Skip to content

Arm backend: Add sign decomposition pass and test #12159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Arm backend: Add sign decomposition pass and test #12159

merged 2 commits into from
Jul 3, 2025

Conversation

@tbergkvist
Copy link
Contributor

@tbergkvist tbergkvist commented Jul 2, 2025 •
edited by pytorch-bot bot
Loading

Decomposes sign into other operators.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Arm backend: Add sign decomposition pass and test
78d1879 
Decomposes sign into other operators.

Signed-off-by: Teo Bergkvist <teo.bergkvist@arm.com>
Change-Id: I36c43bc0a78e019516ad6b643b4c7dc7cbf07d7c
@tbergkvist tbergkvist requested a review from digantdesai as a code owner July 2, 2025 07:46
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12159

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 4 Unrelated Failures

As of commit 56ec087 with merge base 29858b4 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2025
@tbergkvist
Copy link
Contributor Author

tbergkvist commented Jul 2, 2025

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jul 2, 2025
@tbergkvist
Copy link
Contributor Author

tbergkvist commented Jul 2, 2025

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot bot added the release notes: arm Changes to the ARM backend delegate label Jul 2, 2025
@tbergkvist
Copy link
Contributor Author

tbergkvist commented Jul 2, 2025

@pytorchbot label "ciflow/trunk"

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 2, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Jul 3, 2025
@zingo
Copy link
Collaborator

zingo commented Jul 3, 2025

broke jobs underlated qnn job as runned for 4h, ignoreing, should be unrelated to this PR anyway.

@zingo zingo merged commit d533a87 into pytorch:main Jul 3, 2025
192 of 198 checks passed
@tbergkvist tbergkvist deleted the Add-sign-decomposition-pass-and-test branch July 4, 2025 07:12
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
@tbergkvist @Tanish2101
Arm backend: Add sign decomposition pass and test (pytorch#12159)
b4890eb 
Decomposes sign into other operators.

Signed-off-by: Teo Bergkvist <teo.bergkvist@arm.com>
digantdesai
digantdesai reviewed Jul 10, 2025
View reviewed changes
backends/arm/test/ops/test_sign.py

@common.XfailIfNoCorstone300
@common.parametrize("test_data", test_data_suite)
@pytest.mark.xfail(reason="where.self not supported on U55")
Copy link
Contributor

@digantdesai digantdesai Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we stop the sign ops from partition on U55 by adding it in EthosU55NotSupported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai left review comments

@zingo zingo zingo approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tbergkvist @zingo @digantdesai @robell @facebook-github-bot