NXP backend: Improve quantization annotation process #11908
Draft
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11908
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 338c637 with merge base 75e4044 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
- fixes multiple subsequent nodes with SharedSpecPattern problem
StrycekSimon
force-pushed
the
upstream/main-nxp/EIEX-300-upstream-quantization-annotation-improvements
branch
from
be6144f to
338c637
Compare
|
@pytorchbot label "module: nxp" "release notes: nxp" |
pytorch-bot
bot
added
module: nxp
|
Can you provide a little more info on what this is solving? Perhaps a test to illustrate/prove that is now correct and ensure no regression later |
|
Since the I will add a test that covers this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses multiple subsequent nodes with SharedSpecPattern problem.
cc @digantdesai @JakeStevens