Skip to content

Resolve buck earlier #11451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Resolve buck earlier #11451

merged 1 commit into from
Jun 6, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Jun 6, 2025

Summary

Since we resolve buck2 later on, it results in the value of buck2 being empty. It now shows the location:

Test plan

$ cmake --preset pybind && cmake --build cmake-out -j $(sysctl -n hw.ncpu)

-- --- Configured Options ---

-- CMAKE_CXX_STANDARD                      : 17
-- CMAKE_SYSTEM_PROCESSOR                  : arm64
-- CMAKE_BUILD_TYPE                        : Debug
-- PYTHON_EXECUTABLE                       : /Users/jathu/executorch/.venv/bin/python3
-- BUCK2                                   : /Users/jathu/executorch/buck2-bin/buck2-2025-05-06-201beb86106fecdc84e30260b0f1abb5bf576988

cc @larryliu0820

Copy link

pytorch-bot bot commented Jun 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11451

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 172 Pending

As of commit 7fd431a with merge base 27cb43d (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 6, 2025
@jathu jathu marked this pull request as ready for review June 6, 2025 19:54
@jathu jathu merged commit 09a4b9d into main Jun 6, 2025
189 of 192 checks passed
@jathu jathu deleted the jathu/resolve-buck-earlier branch June 6, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants