Skip to content

Restore explicit so load in Module.java #11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Restore explicit so load in Module.java #11385

merged 1 commit into from
Jun 5, 2025

Conversation

GregoryComer
Copy link
Member

Differential Revision: D75994546

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11385

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d12a854 with merge base 3550824 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75994546

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer @facebook-github-bot
Restore explicit so load in Module.java (pytorch#11385)
d12a854 
Summary:
This is a partial revert of pytorch#11058. We are seeing issues with JNI loading on Meta apps. My best guess is that the call to ExecuTorchRuntime is getting optimized out in Module.java, since the result is not used. I'm re-adding the explicit load back until we get that figured out.


Reviewed By: bugraoral, larryliu0820

Differential Revision: D75994546
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75994546

@GregoryComer GregoryComer mentioned this pull request Jun 4, 2025
Merged
@facebook-github-bot facebook-github-bot merged commit bfea626 into pytorch:main Jun 5, 2025
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GregoryComer @facebook-github-bot @larryliu0820