Skip to content

NOCOMMIT: Bisect CoreML failures when bumping PyTorch pin #11222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented May 29, 2025

trunk / test-llama-runner-mac (fp32, coreml) / is failing on #11154. trying to bisect to a PT commit per request from @metascroy

[ghstack-poisoned]
@swolchok swolchok requested a review from GregoryComer as a code owner May 29, 2025 18:30
@swolchok
Copy link
Contributor Author

swolchok commented May 29, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented May 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11222

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 4061a9f with merge base 2e9c71c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: 15b71f4
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok swolchok marked this pull request as draft May 29, 2025 19:17
swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: bcca026
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: c4efef2
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: 770d60c
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: f750703
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: 5d03959
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: f5ca5f8
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: 452a342
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: dd6ac0d
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
[ghstack-poisoned]
swolchok added a commit that referenced this pull request May 29, 2025
ghstack-source-id: 0d97fd0
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
@swolchok
Copy link
Contributor Author

swolchok commented May 29, 2025

bisects to 7e80f23516a86e18ae5bc5579d3005c1e7610102, which is pytorch/pytorch#153795
CC @angelayi

@metascroy
Copy link
Contributor

bisects to 7e80f23516a86e18ae5bc5579d3005c1e7610102, which is pytorch/pytorch#153795 CC @angelayi

This is quite interesting. It's hard to see how @angelayi's PR could have affected the LLM model accuracy for CoreML. Are you sure on the bisect @swolchok?

@swolchok
Copy link
Contributor Author

bisects to 7e80f23516a86e18ae5bc5579d3005c1e7610102, which is pytorch/pytorch#153795 CC @angelayi

This is quite interesting. It's hard to see how @angelayi's PR could have affected the LLM model accuracy for CoreML. Are you sure on the bisect @swolchok?

yes, unfortunately we don't have CI history for each version of this PR but I believe you can see the commit history. all I did was change the hash in this diff and record whether the job in the summary succeeded. I can repeat the test for the blame rev and previous rev to make sure it's not just flaky

swolchok added a commit that referenced this pull request May 30, 2025
ghstack-source-id: f750703
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
@swolchok
Copy link
Contributor Author

I confirm that test-llama-runner-mac (fp32, coreml) https://github.com/pytorch/executorch/actions/runs/15351527127/job/43200693055?pr=11222 fails with the blamed commit

swolchok added a commit that referenced this pull request May 30, 2025
ghstack-source-id: 0d97fd0
ghstack-comment-id: 2920234223
Pull-Request-resolved: #11222
@swolchok
Copy link
Contributor Author

I confirm that test-llama-runner-mac (fp32, coreml) https://github.com/pytorch/executorch/actions/runs/15351973357/job/43202245242?pr=11222 succeeds with the commit immediately prior to the blamed commit. @metascroy bisect confirmed

@angelayi
Copy link
Contributor

Is it possible to repro this accuracy issue locally? I'm a little confused why my changes would break the coreml test, unless coreml is somehow using aotinductor under the hood?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants