-
Notifications
You must be signed in to change notification settings - Fork 573
NOCOMMIT: Bisect CoreML failures when bumping PyTorch pin #11222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11222
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 4061a9f with merge base 2e9c71c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
[ghstack-poisoned]
bisects to 7e80f23516a86e18ae5bc5579d3005c1e7610102, which is pytorch/pytorch#153795 |
This is quite interesting. It's hard to see how @angelayi's PR could have affected the LLM model accuracy for CoreML. Are you sure on the bisect @swolchok? |
yes, unfortunately we don't have CI history for each version of this PR but I believe you can see the commit history. all I did was change the hash in this diff and record whether the job in the summary succeeded. I can repeat the test for the blame rev and previous rev to make sure it's not just flaky |
[ghstack-poisoned]
I confirm that test-llama-runner-mac (fp32, coreml) https://github.com/pytorch/executorch/actions/runs/15351527127/job/43200693055?pr=11222 fails with the blamed commit |
[ghstack-poisoned]
I confirm that test-llama-runner-mac (fp32, coreml) https://github.com/pytorch/executorch/actions/runs/15351973357/job/43202245242?pr=11222 succeeds with the commit immediately prior to the blamed commit. @metascroy bisect confirmed |
Is it possible to repro this accuracy issue locally? I'm a little confused why my changes would break the coreml test, unless coreml is somehow using aotinductor under the hood? |
trunk / test-llama-runner-mac (fp32, coreml) / is failing on #11154. trying to bisect to a PT commit per request from @metascroy